Properly encode content-disposition header #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Wallis <mrdanwallis@gmail.com>
Signed-off-by: Dan Wallis <mrdanwallis@gmail.com>
weierophinney
added a commit
that referenced
this pull request
Jun 30, 2020
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
|
Thanks, @fredden! Merged to develop for release with 2.11.0. |
|
This looks like huge copy-paste from some other class... 🤔 |
artemii-karkusha
pushed a commit
to artemii-karkusha/laminas-mail
that referenced
this pull request
May 24, 2023
Properly encode content-disposition header
artemii-karkusha
pushed a commit
to artemii-karkusha/laminas-mail
that referenced
this pull request
May 24, 2023
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #2
This is a port of zendframework/zend-mail#251 to this repository per zendframework/zend-mail#251 (comment).
When using UTF-8 encoding, this codebase was producing a header being of
Content-Disposition: =?utf-8?Q?inline?=which is not interpreted properly by Thunderbird nor Microsoft Outlook. This pull request introduces specific handling of this header, so thatinlinewill never be encoded as UTF-8 and therefore cannot be misinterpreted by some user agents.This is a proper fix for magento/magento2#25076. The work-around applied there was to no longer set a
content-dispositionheader.